search

josesamuel / remoter

Remoter - An alternative to Android AIDL for Android Remote IPC services using plain java interfaces
Apache License 2.0
84 stars 14 forks source link

Throw unchecked exception in case of a oneway call on the service side #5

Closed St3ffn closed 5 years ago

St3ffn commented 5 years ago

Fix regarding issue https://github.com/josesamuel/remoter/issues/4

josesamuel commented 5 years ago

Thanks for the PR, but the submitted changes cannot be merged as such as the exception can't be thrown as such from that method. It needs to be wrapped as a RuntimeException. I can make that change in the next update.

St3ffn commented 5 years ago

As you mentioned in https://github.com/josesamuel/remoter/issues/4 this issue will be fixed in 1.2.4. Can I expect that version soon? If not I can also offer my help to adapt the PR to wrap it in a RuntimeException. Thanks in advance.

josesamuel commented 5 years ago

yes it is already released.. should be available in mavencetral in a couple of hours

On Fri, Jun 14, 2019 at 2:00 PM st3ffn notifications@github.com wrote:

As you mentioned in #4 https://github.com/josesamuel/remoter/issues/4 this issue will be fixed in 1.2.4. Can I expect that version soon? If not I can also offer my help to adapt the PR to wrap it in a RuntimeException. Thanks in advance.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/josesamuel/remoter/pull/5?email_source=notifications&email_token=AFIEC2GK4R4FXYADXW4KMXTP2PTGRA5CNFSM4HYHZ3N2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXXV5LA#issuecomment-502226604, or mute the thread https://github.com/notifications/unsubscribe-auth/AFIEC2GNEXKAF2O7RRYXS5DP2PTGRANCNFSM4HYHZ3NQ .

St3ffn commented 5 years ago

Perfect. Thanks a lot for your effort.