josesamuel / remoter

Remoter - An alternative to Android AIDL for Android Remote IPC services using plain java interfaces
Apache License 2.0
84 stars 14 forks source link

package org.parceler does not exist #6

Closed y-a-n-n closed 4 years ago

y-a-n-n commented 4 years ago

Hi! Great library.

Just encountered this issue when using remoter for a kotlin interface. I included the library using a kapt annotation processor:

implementation 'com.josesamuel:remoter-annotations:1.2.4'
kapt 'com.josesamuel:remoter:1.2.4'

The annotation processor runs correctly and generates my proxy and stub, but at compile time throws the error package org.parceler does not exist whenever the generated stub tries to call org.parceler.Parcels.wrap().

Adding the following to my build.gradle works around the issue, but shouldn't Parceler be a transitive dependency?

implementation 'org.parceler:parceler-api:1.1.12'
kapt 'org.parceler:parceler:1.1.12'
josesamuel commented 4 years ago

parceler dependency is needed only if any of the parameters in the interface is a @Parcel. In other cases, it is not needed. That is the reason why it was not made transitive dependent. I will make it clear in the document that if a @Parcel is used, this dependency needed to be manually added.

Thanks!

On Fri, Nov 1, 2019 at 1:30 AM Yann notifications@github.com wrote:

Hi! Great library.

Just encountered this issue when using remoter for a kotlin interface. I included the library using a kapt annotation processor:

implementation 'com.josesamuel:remoter-annotations:1.2.4' kapt 'com.josesamuel:remoter:1.2.4'

The annotation processor runs correctly and generates my proxy and stub, but at compile time throws the error package org.parceler does not exist whenever the generated stub tries to call org.parceler.Parcels.wrap().

Adding the following to my build.gradle works around the issue, but shouldn't Parceler be a transitive dependency?

implementation 'org.parceler:parceler-api:1.1.12' kapt 'org.parceler:parceler:1.1.12'

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/josesamuel/remoter/issues/6?email_source=notifications&email_token=AFIEC2EIGUMBLFUS7D4R5H3QRPEIDA5CNFSM4JHWYOP2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HWASNHA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFIEC2FJPJWCYN6IMT2EUSLQRPEIDANCNFSM4JHWYOPQ .

y-a-n-n commented 4 years ago

No problem, thanks for the clarification.