search

josh- / CloudyTabs

CloudyTabs is a simple menu bar application that lists your iCloud Tabs.
http://joshparnham.com/projects/cloudytabs/
789 stars 52 forks source link

Fix condition where unnamed tab will prevent layout of remaining tabs #42

Closed ctbeiser closed 6 years ago

ctbeiser commented 6 years ago

I found that only the menus for my first device were laying out. It turns out that I had a tab whose title was returning as null, and adding null as the title would raise an exception in NSDictionary.

This PR fixes that by providing a fallback value.

josh- commented 6 years ago

Awesome find, thanks mate! 👌

What are your thoughts on using URL as the title instead of "Untitled Tab" for instances like this?

Would mean that we don't have to translate "Untitled Tab" into the languages that CloudyTabs supports, whilst also providing more context to the user about which site the untitled tab came from (without needing to hover over it to get the URL in the tooltip)

ctbeiser commented 6 years ago

Ooh, I like that. Will update the PR later today.

ctbeiser commented 6 years ago

Alright; feel free to review again