search

josh-berry / tab-stash

Firefox extension to save and restore tabs as bookmarks. Clear your tabs, clear your mind.
https://josh-berry.github.io/tab-stash/
Mozilla Public License 2.0
791 stars 45 forks source link

Option to choose which UI to open with the global keyboard shortcut #132

Open redactedscribe opened 3 years ago

redactedscribe commented 3 years ago

Problem Statement

I'd like to avoid the circumstances of potentially stashing all tabs. I'm more comfortable stashing a single tab at a time.

Preferred Solution(s)

The options that the toolbar button / Ctrl + Alt + W is limited to are:

As indicated by the title of the issue, an intermediary option of "Stash the active tab (or selected tabs)" would be appreciated.

This would make the toolbar button / keyboard shortcut more useful to me: Stashes a single tab at a time (no large mistakes), or stash a bunch of selected tabs at once (unlikely to be a mistake due to the explicit steps required).

Alternative Solution(s)

Maybe "Stash active" option should default to being "(or selected)" just like the first option? No need for a fourth option then, but rather a modification to the current option.

Additional Context

As mentioned in my #131 issue, "Maybe the keyboard shortcut could be configured whether to open the sidebar, tab, or popup view?". The reason why this would be useful to me is that I could have one shortcut that I know simply opens the UI (sidebar/tab/popup) via Ctrl + Alt + S, and another that triggers the toolbar button's assigned action: via Ctrl + Alt + T. As far as I'm aware, as it currently stands there is no way to only open UI in a tab without also sacrificing be able to trigger a useful stashing command such as detail above, as they both rely upon the configured state of the latter keyboard shortcut.

Readers: If you are also interested in seeing this feature be developed, please vote for it by giving the ORIGINAL POST a thumbs-up using the :smiley: button. You are welcome to leave comments and discuss the feature request, but "Me too!" comments are not counted by the voting system.

josh-berry commented 3 years ago

Yeah, I am thinking of revisiting this in a major (like 3.0) release; see #74, because I also find that most of the time, I myself do not want to stash ALL tabs, just some subset. The blocker here is having true multi-selection in the UI (#57), so that it's still easy/convenient to stash lots of tabs.

Do you think #74 would cover the issue you're describing here? Or is there still something I'm missing that isn't covered by that issue?

redactedscribe commented 3 years ago

Thanks for the reply.

74 should cover my use case I believe; Stash Tab / Stash Selected Tabs as a combined action, and Stash All as its own action. I dislike the stash all feature enough that I'd prefer it not even being displayed in any of the context menus. Every time I want to stash tabs, I become acutely aware of wanting to avoid hitting "Stash Tabs" menu option by mistake. Maybe it could be optionally tucked away somewhere so it's still accessible for the rare cases I'd want it, but to not be a listed option using my preferred method of accessing the actions. Maybe it's a bit irrational, but it's really quite annoying to accidentally trigger that feature, in OneTab too.

The only other thing I suggested was a separate shortcut dedicated to opening the UI so that you won't have to choose between doing that or stashing tabs.

josh-berry commented 3 years ago

Got it, thanks. I'll re-title this issue to cover just the keyboard shortcut then and keep #74 for the stash/stash selected issue.