josh-berry / tab-stash

Firefox extension to save and restore tabs as bookmarks. Clear your tabs, clear your mind.
https://josh-berry.github.io/tab-stash/
Mozilla Public License 2.0
780 stars 45 forks source link

Open all tabs in group duplicates each tab (containers) #385

Open dadinn opened 1 year ago

dadinn commented 1 year ago

System Details

Installed Browser Extensions:

Multi Account Containers (known to cause problems)

Universal Bypass (could be causing problems)

Describe the Bug

When I open all items in a group of tabs, I get lots of duplicated tabs.

Steps to Reproduce

Go to Tab Stash page/sidebar point at the green icon above group to Open all tabs in this group.

image

Expected Behavior

Even though Multi-Account Containers plug-in seems to be responsible for this (forcing to always open certain sites in specific containers), it would be nice if this behaviour could be controlled somehow.

Maybe some asynchronous callback callback with timer delay to hide/remove duplicated tabs (maybe checking whether they are in different container)?

Tab Stash already seems to do a similar thing when opening all tabs in a group, by automatically removing the empty New Tab when done in a fresh new window.

Impact

It is very annoying, as grouping tabs based on my activities in given contexts is my main workflow.

Additional Details

N/A


Readers: If you are also experiencing this bug, please vote for it by giving the ORIGINAL POST a thumbs-up using the :smiley: button. You are welcome to leave comments and discuss the issue if you have more details to add, but "Me too!" comments are not counted by the voting system.

josh-berry commented 1 year ago

Hi, I'm not able to find the "Universal Bypass" addon you're talking about—can you provide a link?

I did some testing with Multi-Account Containers ("MAC"), and what I see is that MAC itself will open new tabs when the tab is first loaded, and then not close the prior tab. So I think this is a bug in MAC itself, and not in Tab Stash.

Worse, it seems that even when Tab Stash opens a new tab that should be in a container and asks for it to be loaded, Firefox itself is not loading the tab as expected. So this seems like a bug in Firefox itself, and there's unfortunately not much I can do here.

There is not really a way to identify when this is happening—because of the Firefox bug, loading the tab is dependent on the user clicking on it. And the user very well may have legitimate duplicate tabs, so having Tab Stash randomly/after a delay close duplicates is not going to work.

Sorry to be the bearer of bad news, but there's unfortunately not much I can do here. I can try to understand a little more why this is happening to make proper bug reports (it seems to be a relatively recent occurrence), but the fixes will have to be in Firefox and MAC, not in Tab Stash.

dadinn commented 1 year ago

https://universal-bypass.org/

Oh, actually you are right, it seems this add-on is obsolete by now. Maybe I should remove it too, just in case.

Chealer commented 2 months ago

Could you clarify the symptoms? Is this reproducible?