josh-berry / tab-stash

Firefox extension to save and restore tabs as bookmarks. Clear your tabs, clear your mind.
https://josh-berry.github.io/tab-stash/
Mozilla Public License 2.0
777 stars 44 forks source link

Tab Stash fails to start - bookmark DB errors #417

Closed che-rusker closed 10 months ago

che-rusker commented 11 months ago

As the title says. Not much more to add.

I see he addon active up right with the other addons. But right-click on a tab does not do anything. No matter if the stash is configured to appear in the sidebar or in a new tab.

100% Dysfunctional.

None of the usual suspects is active here.

josh-berry commented 11 months ago

I use Tab Stash on a daily basis on Firefox 119 with no issues, and unfortunately there's not much to go on in your report—can you describe, step by step, exactly what you're trying to do and exactly what's not working?

Also, can you please answer the questions that were in the original bug report form:

Thanks!

che-rusker commented 11 months ago

I'll add some scrots.

scrot_2023-10-29_213339 scrot_2023-10-29_213132 scrot_2023-10-29_213054

This is w11.

josh-berry commented 11 months ago

Thanks! Can you check for error logs from the background page, as described here:

https://github.com/josh-berry/tab-stash/wiki/Collect-Error-Logs

This should hopefully shed some light on why the context menu is not appearing.

che-rusker commented 11 months ago

scrot_2023-10-29_215117

Does this help you on?

Mic

josh-berry commented 11 months ago

It does, thanks. It's telling me Tab Stash is having trouble loading your bookmarks. My best guess is Firefox is reporting inconsistent information about which bookmarks are in which positions.

Did you start using any of the other bookmarks extensions (Auto-Sort or Bookmarks Organizer) recently? I've seen issues happen in the past where multiple extensions are trying to re-organize bookmarks at the same time, their updates conflict with each other, and it leaves your bookmark database in a bad state.

If you can avoid using extensions that automatically make changes to your bookmarks, you can avoid this problem in the future. It's only when two extensions are trying to change things at once that you can run into problems.

My best suggestion would be to export your bookmarks from Firefox's built-in bookmark manager, re-import them, and then delete the old copy once you've verified the re-imported bookmarks look good.

Screenshot 2023-10-29 at 14 10 18

Then, once you've fixed up your bookmarks, restart your browser to get Tab Stash to restart, and hopefully everything should start working again.

Hope this helps, let me know how it goes!

che-rusker commented 11 months ago

Well, I do sort my bookmarks eventually. But not automatically. Okay, I'll try the export/import thing. :)

I'll report back.

che-rusker commented 11 months ago

scrot_2023-10-30_121027

Wohoo! Many thanks, Josh. That did the trick. 😊

I exported all bookmarks as json and as html, as I usually do on a regular basis. AND I deleted them all in FF. After re-import Tab Stash is working fine again!

I really like your addon, as it is extremely helpful when doing research or collecting recipes and stuff. I let the stashed items be presented in a tab AND make this tab sticky. This makes for an ideal workflow (for me).

Mic

josh-berry commented 11 months ago

Hi Mic, glad to hear things are working again! I'll keep this open and see if there's a way to make Tab Stash more resilient against this type of issue in the future, but I'm happy to hear the workaround worked for you!

josh-berry commented 10 months ago

Converting back into a bug since others are hitting this as well. Will look into doing a bugfix release for this.

🔗 This comment has a workaround to get Tab Stash working again 🔗

For any new folks running into this, please see the linked comment above. (No need to leave a "Me Too" comment if this fixes it. But if the above doesn't work for you, it's probably a different issue, so please file a new bug, thanks!)

josh-berry commented 10 months ago

The above fix will at least prevent the crash from happening. However, bookmarks might show up in the "wrong" order and/or drag-and-drop might put things in the wrong places. There's unfortunately nothing to be done about this without a fix in Firefox itself. But this should at least keep Tab Stash usable if this happens in the future.

The fix will be included in the next release.