search

josh-berry / tab-stash

Firefox extension to save and restore tabs as bookmarks. Clear your tabs, clear your mind.
https://josh-berry.github.io/tab-stash/
Mozilla Public License 2.0
807 stars 45 forks source link

Guess at a group name based on search-engine search terms #498

Open josh-berry opened 4 months ago

Chealer commented 3 months ago

I'm not sure what exactly this tracks, but it may be better to prompt for a name when stashing a group of tabs. A non-empty default value could be set either by:

  1. Using the window title, although Firefox (unlike Chromium) doesn't natively allow titling windows (see the Window Titler extension). I would find integration with Window Titler a great progress.
  2. Using the contents of tabs. Window Titler's ticket #75 is very similar and Tab Stash could implement the same without relying on Window Titler.

This really goes to show how related these 2 extensions are. It's particularly sad that they conflict on Window Titler's default keyboard shortcut (Ctrl+Alt+T). And I'm afraid Window Titler is the one which needs/deserves that shortcut the most. I know this massively exceeds this ticket's scope, but I'd still like to use the occasion to throw the idea of merging Window Titler into Tab Stash. While their features are different, we could say their purpose is the same if we consider it as managing tab proliferation. I find it poor that we need to install an extension just to be able to name windows. Considering that titling windows is built in Chromium, it's unlikely that someone who goes through the "trouble" of installing, learning (and likely searching for) Tab Stash would have so little interest in the ability to title windows as to find the insignificant extra footprint detrimental.

I'm thinking this conflict could have a pretty simple solution: Make Ctrl+Alt+T bring up a dialog similar to Window Titler's with a simple change: rather than just an OK button, offer 2 options: a "Just title" button or a "Stash" button. This way, stashing would gain the great ability to name directly, at the only cost of 1 extra keypress in the worst case.

josh-berry commented 3 months ago

Prompting is definitely not what I want here; that would increase rather than reduce friction. It's already quite easy to rename a group just by clicking on its title. The goal here is to auto-detect the group name based on a user's search in an open tab that's being stashed, so they don't have to name the group manually.

This is entirely unrelated to window titling.