Prevent duplicate stash operations if a user clicks multiple times by accident

Zanger67 commented 4 months ago

Note: Not too important of an issue imo (rarely occurs) but I thought I'd add the issue for the sake of it

System Details

OS Version: Windows 10 (10.0.19045 Build 19045)
Browser Version: Firefox v128.0 (64-bit)
Tab Stash Version: 3.0.1

Installed Browser Extensions:

LastPass -Momentum
Return YT Dislike
Video Speed Controller

Describe the Bug

During very high CPU/RAM/both usage occasionally when I begin stashing tabs to prepare to restart my browser to empty caches and whatnot, while TabStash is slowly loading / giving me the chance to click "stash" (on a tab of tabstash), I'll click it but thinking after waiting a bit that it wasn't registered the click I click again but see two separate lines of tabs appear.

The newly added tab groups will be identical but separate (exact same tabs in both groups but separate instances that can be modified, closed, opened, etc. independently).

Steps to Reproduce

Overload computer's RAM / CPU with too many tabs from trying to understand TypeScript and Svelte docs (/j)
When Firefox is getting slow (namely slow webpage opening, slow tab switching, multi-second delays for a unpause video click to register) open tab stashes instances on each open window
Rapid click "stash all and close" on a window that has a significant number of tabs open

Expected Behavior

Single instance of window being stashed

Impact

Additional Details

Readers: If you are also experiencing this bug, please vote for it by giving the ORIGINAL POST a thumbs-up using the :smiley: button. You are welcome to leave comments and discuss the issue if you have more details to add, but "Me too!" comments are not counted by the voting system.

josh-berry commented 4 months ago

Fair; thanks for letting me know. Generally, stashing should be pretty fast, but there's probably more that can be done to prevent accidental duplicate clicks. I'll keep this in mind!

Zanger67 commented 4 months ago

Ofc! Don't think it's a pressing issue just an observed thing. The lag part is completely my fault for being too lazy to clean tabs up lol I just happened to notice it in the process.

Thanks for the extension it's been a lifesaver for the past year or so. :)

josh-berry / tab-stash