search

josh-berry / tab-stash

Firefox extension to save and restore tabs as bookmarks. Clear your tabs, clear your mind.
https://josh-berry.github.io/tab-stash/
Mozilla Public License 2.0
795 stars 45 forks source link

Not working- toolbar button and context menu #541

Closed FabEditor closed 3 weeks ago

FabEditor commented 1 month ago

OS Version

Windows 10 Home

Browser Version

131.0 (64-bit)

Tab Stash Version

3.1

Number of Open Tabs

9

Number of Stashed Tabs

25

Total Number of Bookmarks

250

Performance Profile Link

No response

Installed Extensions

Problem Description

When on a website and I click the toolbar button the tab does not stash and I can't open the the context menu

Steps to Reproduce

I don't know

Impact

No response

Additional Details

No response

Vote for This Issue

josh-berry commented 1 month ago

Sorry to hear that! Can you double-check your settings for what is supposed to happen when the Tab Stash toolbar button is clicked?

  1. Go to about:addons
  2. Open Tab Stash
  3. Click on the Preferences tab
  4. Make sure the settings under "Tab Stash Behavior" are what you would expect.

If it's not a settings issue, can you try collecting error logs to see what might be wrong: https://github.com/josh-berry/tab-stash/wiki/Collect-Error-Logs

FabEditor commented 1 month ago

There is this warning: Warning details

Reading manifest: Warning processing page_action.theme_icons: An unexpected property was found in the WebExtension manifest.

FabEditor commented 1 month ago

When I turn off and on the extention - this crash message comes up

Browser: Mozilla Firefox 131.0 20240923135042 (win x86-64) Extension: Tab Stash 3.1 (normal)

bookmark-metadata: Port was disconnected while waiting for response NanoPortError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:168:1 NanoDisconnectedError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:184:5 _flushPendingOnDisconnect@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:90:22 Port/<@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:27:12

favicons: Port was disconnected while waiting for response NanoPortError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:168:1 NanoDisconnectedError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:184:5 _flushPendingOnDisconnect@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:90:22 Port/<@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:27:12

bookmark-metadata: Port was disconnected while waiting for response NanoPortError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:168:1 NanoDisconnectedError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:184:5 _flushPendingOnDisconnect@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:90:22 Port/<@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:27:12

favicons: Port was disconnected while waiting for response NanoPortError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:168:1 NanoDisconnectedError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:184:5 _flushPendingOnDisconnect@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:90:22 Port/<@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:27:12

bookmark-metadata: Port was disconnected while waiting for response NanoPortError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:168:1 NanoDisconnectedError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:184:5 _flushPendingOnDisconnect@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:90:22 Port/<@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:27:12

favicons: Port was disconnected while waiting for response NanoPortError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:168:1 NanoDisconnectedError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:184:5 _flushPendingOnDisconnect@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:90:22 Port/<@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:27:12

josh-berry commented 1 month ago

(I assume you didn't intend to close this, so I'm reopening it.)

hm, I think that crash is probably expected; Firefox will terminate things in its own way and that can sometimes cause these crashes to appear when disabling the add-on. Normally what should happen is it simply unloads the preferences page / UI, but if it happens to terminate the background page first, you'll see this crash.

The manifest warning is also expected. If that is the only thing you saw in the background page, it seems unlikely there were any crashes.

What did you find from your settings?

FabEditor commented 4 weeks ago

Can you see the images ?

tab stash part 1 tab stash part 2

josh-berry commented 3 weeks ago

I can, thanks for sharing. It appears you have actually turned off stashing in your preferences:

screenshot

FabEditor commented 3 weeks ago

Thank you for your response and I have changed the setting but it still crashing and not working. How do I stop it? Thank you for your time.

Browser: Mozilla Firefox 131.0 20240923135042 (win x86-64) Extension: Tab Stash 3.1.1 (normal)

favicons: Port was disconnected while waiting for response NanoPortError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:168:1 NanoDisconnectedError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:184:5 _flushPendingOnDisconnect@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:90:22 Port/<@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:27:12

bookmark-metadata: Port was disconnected while waiting for response NanoPortError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:168:1 NanoDisconnectedError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:184:5 _flushPendingOnDisconnect@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:90:22 Port/<@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:27:12

favicons: Port was disconnected while waiting for response NanoPortError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:168:1 NanoDisconnectedError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:184:5 _flushPendingOnDisconnect@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:90:22 Port/<@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:27:12

bookmark-metadata: Port was disconnected while waiting for response NanoPortError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:168:1 NanoDisconnectedError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:184:5 _flushPendingOnDisconnect@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:90:22 Port/<@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:27:12

favicons: Port was disconnected while waiting for response NanoPortError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:168:1 NanoDisconnectedError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:184:5 _flushPendingOnDisconnect@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:90:22 Port/<@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:27:12

bookmark-metadata: Port was disconnected while waiting for response NanoPortError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:168:1 NanoDisconnectedError@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:184:5 _flushPendingOnDisconnect@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:90:22 Port/<@moz-extension://63e897d7-e701-4692-b55a-31a50d3a4c6e/assets/oops-notification.js:27:12

josh-berry commented 3 weeks ago

If you're not seeing any crashes from the background page (here's the link again for how to find background page logs in case it helps), I have to admit I'm honestly stumped.

A few more things we can look into:

  1. Can you try restarting Firefox without any saved session data: https://github.com/josh-berry/tab-stash/wiki/Restart-Firefox-Without-Saved-Session-Data
  2. Try completely uninstalling and reinstalling Tab Stash (disabling it is not sufficient). You don't need to worry about losing any saved tabs since they are stored directly in your bookmarks.
  3. Have you changed any of Firefox's privacy and security settings? For example, have you told Firefox to stop remembering history?

Also, you mentioned the context menu not working--if you right click in an open tab, do you see any Tab Stash context menu entries at all? Or are these completely missing?

If you can see the menu entries, does the "Show Stashed Tabs in a Tab" entry work at all?

Screenshot 2024-10-12 at 13 50 13

If you can see the context menu, and clicking on the context menu entry doesn't work, it might be worth double-checking to see if there were any more crashes in the background page.

Let me know what you find!

FabEditor commented 3 weeks ago

Hi, I just did a reset on the firefox and it seems to works now. But it stop working when I change the History setting to custom and "always use private browsing mode".

Why can't I change it to private browsing?

josh-berry commented 3 weeks ago

Got it—you can't do that because it completely disables all storage for extensions, which means Tab Stash has no way to store things like website icons, deleted items (for the undo feature), or even settings. So unfortunately it just breaks a lot of things Tab Stash depends on.

As a workaround, you can keep your history settings the same (turn off "Always use private browsing mode"), always use private-browsing windows, and turn on the "Run in Private Windows" setting in Tab Stash. This still allows Tab stash to store its settings and such, but still gives most of the private-browsing functionality otherwise.

Hope this helps!

FabEditor commented 3 weeks ago

Thank you very much for your help!

josh-berry commented 3 weeks ago

Sure thing! I'll close this out then.

(dup of #102)