josh-berry / tab-stash

Firefox extension to save and restore tabs as bookmarks. Clear your tabs, clear your mind.
https://josh-berry.github.io/tab-stash/
Mozilla Public License 2.0
801 stars 45 forks source link

Append to top group only works if NOT CUSTOMISED group #556

Open oehm-smith opened 1 week ago

oehm-smith commented 1 week ago

OS Version

MacOS 14.7 Sonoma

Browser Version

Firefox 132.0.1

Tab Stash Version

3.1.1

Non-Standard Browser Settings

n/a

Installed Extensions

None. I created a fresh FF profile and installed TS.

Problem Description

Appending to top-most group only works for a TS created group with time/date name. If you rename to create named groups they aren't used.

Steps to Reproduce

  1. Start fresh profile so know it is not another extension
  2. Launch profile
  3. Install Tab Stash
  4. Turn on advanced settings and make sure 'when stashing a single tab: append to top group...' has a minute value
  5. Create 3 new tabs
  6. Save No_1 as stash (I have 'stash active tab' and 'show the stash in the sidebar') and it appears in dated group
  7. Save No_2 as stash and it goes to same group
  8. Rename group
  9. Save No_3 as stash and it goes to new dated group

Expected Behavior

The stashed tabs (within time window) should go to top-most regardless of it's name.

Impact

This is obviously not a killer bug. But it could cause 'data loss' if you create a named group (*) and expect stashed tabs to go there. Don't get me wrong - this Extension is AMAZING for productivity. It would be nice if it was closer to perfect!

(*) - I have billions of tabs opened and I haven't found a good way of managing it that isn't overly onerous. TS is close to being that. I will make it a pillar of my Firefox productivity.

To make perfect:

Additional Details

No response

Vote for This Issue

oehm-smith commented 1 week ago

I found a decent work-a-round. It is no different to stashing to a dated group and moving from there except that it removes the step of stashing first. All the other problems with this exist (like if you forget to do it, or which named group does this belong to)

josh-berry commented 5 days ago

Hi, thanks for reaching out. This is actually intentional (though perhaps the setting should better-explain this)—un-named groups work slightly differently in two ways:

  1. When stashing from the address bar, or using the blue buttons next to "Unstashed Tabs", as you noticed. Tab Stash deliberately does not stash to a named group, because it doesn't know whether you're intending to add the tab to an existing group or start a new group, and it's much easier to combine an unnamed group with a named group than it is to find a tab that was stashed in the wrong named group by mistake.
  2. When moving things out of an unnamed group, if the unnamed group becomes empty, it is automatically deleted.

You CAN stash directly to a desired group from the Tab Stash UI if you want—there are a couple ways to do it:

Hope that helps, let me know if you have any more questions!