Make "Stash all" labeling more explicit for selected/unselected cases

[josh-berry]

Problem Statement

Per comments in #74, the "Stash Tabs" wording is confusing/ambiguous because sometimes it's "Stash All Tabs" and sometimes it's "Stash Selected Tabs".

Preferred Solution(s)

Detect when tabs are multi-selected and change this wording accordingly in a few places:

• Menus (browser-toolbar and page context)
• Browser toolbar icon
• Stash UI toolbar icons

---

Readers: If you are also interested in seeing this feature be developed, please vote for it by giving the ORIGINAL POST a thumbs-up using the :smiley: button. You are welcome to leave comments and discuss the feature request, but "Me too!" comments are not counted by the voting system.

[joshgold22]

My biggest concern was that (if I'm correct about what happened) I selected Stash Tabs in the menu and it stashed all of my tabs, rather than just the selected one. The critical/urgent thing for me is to include the word All (or All in Window) if it's going to affect all.

[joshgold22]

Maybe I'm misunderstanding something though. I thought my "urgent" ask from #74 was trivial (insert "all"), but when you say on the other ticket it would take some work and require dynamic updating, perhaps I'm still not right about what the current menus do.

[joshgold22]

Can I suggest one more tweak that is at the same level of short-term urgency for me — the toolbar button. This was the cause of another really disruptive accidental stash-all for me today, so I'm hoping you can bundle a change to that with the other short-term context menu fix.

Perhaps it's because I use "close" rather than "hide" but it becomes a big mess if I click it by accident and need to recover a large set of tabs. I've already on some occasions clicked it expecting to open the menu of actions (wrong kind of click), and other times clicked it intending to select another toolbar button with a similar icon.

Perhaps for the short term you could change the behavior to just open the menu, same as secondary click. In the longer term, I think confirmation dialogs will help across the board (perhaps with option to disable), and I'd still suggest to have it default to opening the menu on click, but there could be a preference to select the 1-click behavior (menu, stash all, or stash selected)

[josh-berry]

Maybe I'm misunderstanding something though. I thought my "urgent" ask from #74 was trivial (insert "all"), but when you say on the other ticket it would take some work and require dynamic updating, perhaps I'm still not right about what the current menus do.

"Stash tabs" is really either "Stash all tabs" or "Stash selected tabs". So inserting the right word ("all" or "selected") requires knowing whether multiple tabs are selected or not and updating the menu accordingly. Right now all those menus are generated once when the extension is first loaded, so the "dynamic updating" part of this is just knowing which situation we are in and updating the menu accordingly.

Perhaps for the short term you could change the behavior to just open the menu, same as secondary click. In the longer term, I think confirmation dialogs will help across the board (perhaps with option to disable), and I'd still suggest to have it default to opening the menu on click, but there could be a preference to select the 1-click behavior (menu, stash all, or stash selected)

Unfortunately I think it's going to get confusing and frustrating for a lot of folks (who would have to change their habits/muscle memory) if the behavior of the toolbar button changes multiple times, so my preference is to do it once, the right way (i.e. make it configurable and have a sane(r) default), a la #21.

[joshgold22]

That helps me see the different picture I had in mind. I'd assumed that the basic behavior, if you have not used multi-selection, is to just stash this tab, the active one. Stashing All seems like a big gun to me, so I figured all along that was something you'd do with extra effort and confirmation (and I hadn't used the extension enough to realize my mental model was wrong until you said that and it clicked.) I still like mine better :-) and would like a quick action to stash the active tab, but I do understand your model better now.

Maybe the quick-fix could just be a confirmation dialog saying "Ok to stash 32 tabs?" (If it's easy to determine which mode, the title of the confirmation dialog could say either Stash All Tabs or Stash Selected Tabs)

[lucatrv]

I think there should be only two options:

• Stash this tab or selected tabs (this would also be shown from the address icon)
• Stash all tabs in this window

With this feature, you would not need the "Stash this tab to a New Group" option, and moreover there would be no need for a confirmation dialog saying "Ok to stash 32 tabs?" (you could just click on "Cancel").