search

josh-collinsworth / sveltekit-blog-starter

A preconfigured SvelteKit static blog starter, with Sass, Markdown, MDSvex, Rehype, background preloading, and more. See the README for full details.
https://sveltekit-static-starter.netlify.app/
MIT License
419 stars 81 forks source link

add prerender.default to build html files for publish #6

Closed JaKXz closed 2 years ago

JaKXz commented 2 years ago

As suggested by sveltekit, so the build folder has html files to start with. I was surprised that this is isn't on by default... it feels like a typo to me but feel free to close this if not!

Love this starter, just gave it a shot and it works fantastic [otherwise]. I was also able to update all dependencies with no issues 🎉 😸

I found that using https://npm.im/gh-pages, I had to set up my deploy script like so:

"predeploy": "npm run build && touch build/.nojekyll",
"deploy": "npx gh-pages -d build -b main --dotfiles"
netlify[bot] commented 2 years ago

❌ Deploy Preview for sveltekit-static-starter failed.

🔨 Explore the source changes: f2081a00dd2b37a40c2398cd077589cca72740b8

🔍 Inspect the deploy log: https://app.netlify.com/sites/sveltekit-static-starter/deploys/622abc42b07af400087ab02a

JaKXz commented 2 years ago

Ah I get it, so I guess it is only necessary for non-edge hosts, like GitHub pages. Sorry for the noise!