[Enhance]: Injecting favicon at the top of head breaks charset. Possible solution provided.

josh-hemphill / vite-plugin-favicon

Leverages on favicons to automatically generate your favicons for you. And if you want to also consolidate your PWA manifest, will generate that as well with linked icons.

MIT License

50 stars 12 forks source link

[Enhance]: Injecting favicon at the top of head breaks charset. Possible solution provided. #11

Closed andreacfromtheapp closed 2 years ago

andreacfromtheapp commented 2 years ago

Prerequisites

[x] I have searched through existing issues

Feature Request

Currently favicons are injected at the top of the <head>. This moves <meta charset="UTF-8" /> further down and breaks its meaning, scope, and functionality.

Since favicons aren't going to suffer from it, it would it be advisable to inject them at the head bottom by default (using 'head' instead of 'head-prepend' should do the trick).

Please and thank you

andreacfromtheapp commented 2 years ago

so, I tried a fix that should do the trick.

However, I'm not opening a PR because I can't understand how to install my own version of the plugin for testing. (I'm very new to Vite).

I hope this helps

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.