Rework Tracking Issue: Package currently not working

josh-hemphill / vite-plugin-favicon

Leverages on favicons to automatically generate your favicons for you. And if you want to also consolidate your PWA manifest, will generate that as well with linked icons.

MIT License

50 stars 12 forks source link

Rework Tracking Issue: Package currently not working #7

Open josh-hemphill opened 3 years ago

josh-hemphill commented 3 years ago

Current TODOs:

[ ] #2
[ ] Update config files' file paths from the file IDs that Vite generates #1
[ ] Finish new image generation library josh-hemphill/favigen that can handle file name updates
[ ] Improve documentation by not listing no-op options, just say it accepts webpack favicon config #6
[ ] Add output path overrides

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

brunodmn commented 2 years ago

Sry, is the plugin working? I've just tried, when I build the app, it generates the icons, but with wrong href on dist/index.html

josh-hemphill commented 2 years ago

Kind of, the html/paths being wrong is a result of the favicons library not exposing any functionality to change or track that part of it. I haven't touched this in a while, but I'm planning to return to it in the next month or so; I'm going to have to write a separate favicon library, because favicons is really not meant to be used as library even though that's what it's most often used for.

brunodmn commented 2 years ago

Got it, thank you for answering.

demc commented 2 years ago

[ ] Finish new image generation library josh-hemphill/favigen that can handle file name updates

Any updates? It appears this library is broken (i.e. the href attributes are wrong upon injection).