search

josh-perry / pokemon-hm-slave-finder

A little project for finding the perfect HM slaves in Pokemon games.
https://josh-perry.github.io/pokemon-hm-slave-finder/
0 stars 2 forks source link

Feature Request: Additional Field Moves #15

Open Alexgopen opened 3 years ago

Alexgopen commented 3 years ago

Would you be willing to add additional field moves to your HM Slave finder, such as: Dig Flash (absent from Gen 4, as it became a TM) Headbutt

josh-perry commented 3 years ago

Hi!

I wasn't planning on it but it's not tricky to do: adding the field moves to the list in scrape_serebii.py (here) does the trick:

field_moves = [
    # Gen 1
    ["cut", "surf", "fly", "strength", "flash", "teleport", "soft-boiled"],
... etc.
]

image

The only reason I haven't done it myself is that I don't like how it comes out in the frontend. The HMs and other misc field moves should be separated imo but the scraper doesn't have a way of writing out which type of move it is.

If you want to make a PR that adds those and formats the checkbox list in a nicer way then I'll happily merge it!

Alexgopen commented 3 years ago

I'm having some trouble with the scraping and running of the site. Could you add me on discord so I can contact you with questions?

Thanks alexx#8708

josh-perry commented 3 years ago

Sure. Can't promise 24 hour support but I'm happy to try and help you get it running.