josh-project / josh

Just One Single History
https://josh-project.github.io/josh/
MIT License
1.48k stars 55 forks source link

Rust 1.80 support #1353

Closed flokli closed 2 months ago

flokli commented 2 months ago

Nixpkgs is updating to Rust 1.80, and we noticed josh stops building with Rust 1.80.

As described in the issue, there's an unfixable build regression in rustc https://github.com/rust-lang/rust/issues/127343, usually requiring bumping a bump of the time crate:

error[E0282]: type annotations needed for `Box<_>`
  --> /build/josh-23.12.04-vendor.tar.gz/time/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
help: consider giving `items` an explicit type, where the placeholders `_` are specified
   |
83 |     let items: Box<_> = format_items
   |              ++++++++
flokli commented 2 months ago

I sent a PR at https://github.com/josh-project/josh/pull/1354.

Would be great if you can tag a release containing this fix once it landed.

flokli commented 2 months ago

Thanks! Can you create a tag containing this?

christian-schilling commented 2 months ago

Thanks! Can you create a tag containing this?

done

flokli commented 2 months ago

Thanks!