search

josh-project / josh

Just One Single History
https://josh-project.github.io/josh/
MIT License
1.48k stars 55 forks source link

Fix round-tripping commits that contain extra headers #1389

Closed bjeanes closed 1 month ago

bjeanes commented 1 month ago

Fixes #1377 Closes #1387

As per https://github.com/josh-project/josh/pull/1387#issuecomment-2355037601 this is how this might look by using the gix-object crate to own the commit object format.

bjeanes commented 1 month ago

I think it's ok to use gix here.

Yeah once I realised (after doing #1387) that it was possible to use gix without using gix's odb or repo, then this was my strong preference for approach. I'm glad you agree. I'll close #1387.

What do you want to do about the /version endpoint and test? I changed the test but I'm not sure if the latest git tag on the repo was meant to be r24.08.14 instead of v24.08.14, to match the previous scheme.

bjeanes commented 1 month ago

Thank you @christian-schilling! What's your approach for release schedule. Now that this is fixed, a release including the fix will unblock my team's adoption of JOSH. Is this something that could be done?

christian-schilling commented 3 weeks ago

Thank you @christian-schilling! What's your approach for release schedule. Now that this is fixed, a release including the fix will unblock my team's adoption of JOSH. Is this something that could be done?

Out approach to release schedule is to release from time to time when major bugs of features where fixed or introduced. But we do run production instances straigt of master. I did tag a new release.