search

josh-richardson / cadmus

A GUI frontend for @werman's Pulse Audio real-time noise suppression plugin
GNU General Public License v3.0
2.09k stars 55 forks source link

Input and output problem Ubuntu 20.04 #36

Open nicolasrojo25 opened 4 years ago

nicolasrojo25 commented 4 years ago

Hi, my problem is that cadmus inverts the output with the sound input, so when I want to apply the cancellation filter, I get cadmus ouput where the microphone is and cadmus sink microphone where the speakers are.

Captura de pantalla de 2020-07-30 21-44-09

richardteachout commented 4 years ago

I have the same problem, replicated. .deb install

joeykrim commented 4 years ago

Same issue on Ubuntu 18.04 image image

mmarsalko commented 4 years ago

Same issue on Pop!_OS 19.04. I see "Cadmus denoised output" under Input Devices, which seems backwards.

Is there a workaround for this, or is it just a bug that needs resolved?

mmarsalko commented 4 years ago

I have a fix in my own fork of Cadmus. Looks like the "control" value was missing in the latest code, so I fixed that up and added a slider so users can dial in their own control level:

https://github.com/mmarsalko/cadmus image

nicolasrojo25 commented 4 years ago

You are a genius, I try it in a few days because I had to go back to windows for my work

marcmacmac commented 4 years ago

Awesome! @mmarsalko do you have a compiled version of your branch that you can share? I'd love to test it, since I have the same issue.

mmarsalko commented 4 years ago

@marcmacmac unfortunately, I don't know how to build binaries for this. There's an included release script, but it requires the use of docker images I don't have access to.

Even with my changes, the reliability still seems pretty finnicky (Really seems to be a PulseAudio issue). If you're able to pull my branch and run it yourself, I'd love to know what your results are. :)

marcmacmac commented 4 years ago

@mmarsalko No worries, I'll check it out these days and let you know. I'm super curious.

marcmacmac commented 4 years ago

@mmarsalko A little late, but I just tested it. Since sip is not avaiable in a 4.x version in the repository anymore, I had to fix dependencies by updating PyQt5 a few minor versions to get sip in a version 5.x. (I just went to the latest PyQt5 5.15 and sip 5.4.0)

Aaaaand it's working. At least for selecting a correct device and the noise suppression. The slider looks broken though. I can click on it, but the window closes and the terminal says always level 50. grafik

BramFr commented 4 years ago

Any update for deb package ?

marcmacmac commented 4 years ago

@BramFr I stopped working on it, since there are too many flaws with it. I tried NoiseTorch and it works like a charm for me.