search

joshaber / Few.swift

Views as functions of their state.
MIT License
1.08k stars 39 forks source link

iOS Table Header & Footer #76

Closed Adlai-Holler closed 9 years ago

Adlai-Holler commented 9 years ago

Here they are – a table view header & footer. With this our iOS table view implementation basically becomes feature-complete, except for editing and animated/incremental updates

joshaber commented 9 years ago

Sorry for not reviewing this yet :disappointed: Soon!

joshaber commented 9 years ago

Sorry for taking so long to get to this :sob: This looks like a pretty sensible direction :+1:

When is it safe (or not safe) to read Element.frame?

Generally elements are laid out after diffing is done. Is there some particular case you're wondering about?

Adlai-Holler commented 9 years ago

@joshaber OK I think this is ready for a legit review. I've updated the iOS demo to have dynamic header and footer heights. One major library-wide change is 5f14ab5

Adlai-Holler commented 9 years ago

@joshaber Would you mind reviewing this?

joshaber commented 9 years ago

Sorry, I somehow missed that this was ready for review!

Adlai-Holler commented 9 years ago

@joshaber Cool, left a couple notes

Adlai-Holler commented 9 years ago

@joshaber Changes made. How's it look?

joshaber commented 9 years ago

:metal: