search

joshaber / Few.swift

Views as functions of their state.
MIT License
1.08k stars 39 forks source link

Store the parent RealizedElement for each cell in the cell itself #86

Closed Adlai-Holler closed 9 years ago

Adlai-Holler commented 9 years ago

@joshaber

joshaber commented 9 years ago

Hmm, it looks like this would have the same retain cycle problem that we had a while back. Once parentElement has been created, it keep a strong reference to self, while self also has a strong reference to parentElement.

Adlai-Holler commented 9 years ago

OK that's true for the Mac one, but not for the iOS one, since iOS uses a separate contentView. I could either revert the Mac-side changes, or create a subview that fills the cell and use that as the root view. What do you think @joshaber ?

joshaber commented 9 years ago

I could either revert the Mac-side changes

Let's just do that for now :+1:

Adlai-Holler commented 9 years ago

Done @joshaber

joshaber commented 9 years ago

:metal: