joshaber / MacShairport

A native Mac Shairport implementation
Other
176 stars 25 forks source link

IPv4 #1

Closed meck closed 13 years ago

meck commented 13 years ago

When trying out with and ios device that only has ipv4, the initial connection responds to the OPTIONS but then the connection don't close and the ANNOUNCE is never received.

As i understand it the ip of the server is included in the encoded apple-response, and there is formatting going on for ipv6 there

joshaber commented 13 years ago

The apple-response assumes ipv6 but our socket is only listening on ipv6. I guess it should be listening on both ipv6 and ipv4 and the apple-response should use the right IP formatting. But it seems weird that the iOS device would do the initial connection to get OPTIONS over ipv6 and then want ipv4.

meck commented 13 years ago

Actually i think it manages to do the initial connection over ipv4 even if that wasn't the thought in the design, if i log remoteIP in initWithSocketHandle it is ::ffff:192.169.135.197 while doing the initial connection to an ios device.

rcarlsen commented 13 years ago

While lacking in debugging info at the moment, I confirm that MacShairport is working using a local connection in iTunes, but an iPhone (iOS 4.3.1) is not playing.

(FYI, I'm rolling this port into my GUI menu widget, ShairPort Menu)

rcarlsen commented 13 years ago

sergioharo's IPv4 commits resolve this for me.

joshaber commented 13 years ago

Awesome! I'll close this then.

rcarlsen commented 13 years ago

I do see a lot of messages about missing frames...perhaps unrelated?

missing frame.
requesting resend on 2 packets (port 49507)