joshbalfour / node-cognitive-services

Microsoft® Cognitive Services SDK for Node.JS
https://www.microsoft.com/cognitive-services
MIT License
105 stars 45 forks source link

regions fix #48

Closed v-geberr closed 6 years ago

v-geberr commented 6 years ago

commonService doesn't consider a service such as LUIS with different points of contact. Instead of correcting commonService, I altered languageUnderstanding to handle the authoring versus querying regions and keys.

miparnisari commented 6 years ago

I'm getting this:

  1) Language understanding (LUIS) Create app before, delete app after should get APP versions:
     AssertionError: expected Array [] to have property length of 3 (got 0)
      at Assertion.fail (node_modules\should\cjs\should.js:275:17)
      at Assertion.value (node_modules\should\cjs\should.js:356:19)
      at promiseDelay.then.then (test\language\languageUnderstandingTest.js:671:73)
      at <anonymous>

  2) Language understanding (LUIS) Create app before, delete app after should get app VERSION info:
     AssertionError: expected Array [] to have property length of 3 (got 0)
      at Assertion.fail (node_modules\should\cjs\should.js:275:17)
      at Assertion.value (node_modules\should\cjs\should.js:356:19)
      at promiseDelay.then.then (test\language\languageUnderstandingTest.js:723:66)
v-geberr commented 6 years ago

@miparnisari Can you run the test again? My tests still pass. Perhaps there was an issue with APP and VERSION info on the LUIS service side when the test was run. If you still get errors, what region are you using? Are you using the authoring key for both authoring and endpoint? I am just because I'm making so few requests.