joshbalfour / node-cognitive-services

Microsoft® Cognitive Services SDK for Node.JS
https://www.microsoft.com/cognitive-services
MIT License
105 stars 45 forks source link

Migrate deprecated Recommendations API #51

Open miparnisari opened 6 years ago

miparnisari commented 6 years ago

New API Reference: https://github.com/Microsoft/Product-Recommendations/blob/master/doc/api-reference.md

jake32321 commented 6 years ago

Hey could I possibly take a crack at this? Could I possibly get a little more information on what needs to be done?

miparnisari commented 6 years ago

Hi @jake32321 !

Microsoft recently updated the recommendations API and changed a bunch of things. So the task is to update the wrapper for this service.

The source code is here and the tests are here.

I've written the code for only one API endpoint, but there are more. The task is to write the functions for all (and obviously the tests).

image

You will need a personal Azure subscription to test this. I think they have a free tier (B1) but i haven't checked if it's actually free.

There are some interesting things, like for example the test for the POST /api/models endpoints will have to have a file uploaded to blob storage. It'd be nice to upload and delete this file in the before and after test functions :)

jake32321 commented 6 years ago

Sounds good! I'll get to cracking on this later.

sabina-rohman commented 4 years ago

@miparnisari Hi, I am first timer. Is this ticket still open? I would like to give it a try?

miparnisari commented 4 years ago

@sabina-rohman sure :)