search

joshbalfour / node-cognitive-services

Microsoft® Cognitive Services SDK for Node.JS
https://www.microsoft.com/cognitive-services
MIT License
105 stars 45 forks source link

Add Video Indexer v2 #66

Open noce2 opened 5 years ago

noce2 commented 5 years ago

To ensure the getAccounts method of v2 of the video indexer api is working properly, I have written a unit test. As the video indexer has a large API, I wanted to do a small PR to check that my approach is correct before I plough ahead with the rest of the work.

miparnisari commented 5 years ago

Thanks @noce2! The 4 tests pass. Only nitpick is the missing catch in the beforeEach. Please fix that and I'll merge.

cornu-ammonis commented 5 years ago

@miparnisari @noce2 I was going to open a PR for this myself but this looks done. If I were to add the catch on the beforeEachwould this still be mergeable?

vatsal2210 commented 5 years ago

Hi @miparnisari, can you close this open request? It would be great for me to continue. Moreover, I tried to look around any file/folder for indexer under vision folder. But I didn't find any.

miparnisari commented 5 years ago

@noce2 can you review my comment and fix the merge conflict?

noce2 commented 5 years ago

sure :)