Segfault when converting a track if the plugin has already initialised

[joshbarrass]

Steps to reproduce: 1) Add one or more GSF files to the playlist 2) Begin playing one of the GSF files 3) Right click on a GSF file in the playlist and select convert 4) Click OK to convert

Expected behaviour:

• Track is converted without error

Actual behaviour:

• Segmentation fault

Workaround:

• The segfault only appears to happen if another GSF file is playing at the same time. If you press STOP (not PAUSE) before converting, the file should convert without issue. You can also restart DeaDBeeF before attempting the conversion if the issue still persists.

[joshbarrass]

This issue most likely comes about as DeaDBeeF attempts to continue playing the current file whilst converting the requested file. This causes the GSF plugin to be reinitialised. Since the plugin uses a global state object, this would cause the state for the currently playing file to be lost, and the segfault probably occurs whenever the DeaDBeeF tries to do something with that file (e.g. calling the read method). Solving #3 should therefore fix this issue.