search

joshbduncan / word-search-generator

Make awesome Word Search puzzles!
MIT License
74 stars 24 forks source link

fpdf2 required version discrepancy in dev requirements #53

Closed duck57 closed 1 year ago

duck57 commented 1 year ago

requirements.txt requires 2.4.2 while requirements-dev.txt demands 2.5.0

The most recent version is 2.7.5

Should both versions be bumped to 2.7.5?

joshbduncan commented 1 year ago

Requirements files are sort of "out of favor" now-a-days. It seems it is becoming more conventional to install requirements via the pyproject.toml file or a packager like hatch/hatchling or poetry. Both requirements files are really just there for anyone who isn't aware of how to install from pyproject.toml. As for bumping the version, I'll have to check their changlog first. Previously, that package has broken something on update.

duck57 commented 1 year ago

2.4.2 is the version in pyproject.toml, so I'll leave it there.

joshbduncan commented 1 year ago

I will check the dependencies for updates before releasing a new version, and update then if need be.

joshbduncan commented 1 year ago

@duck57, turns out the new version of fpdf2 did have some breaking changes but I fixed them and updated the rest of the dependencies while I was at it.