search

joshbetz / Hypersonic

An iOS app for streaming music from a Subsonic server and other cloud services
http://joshbetz.github.com/Hypersonic
15 stars 3 forks source link

No login validation #5

Closed joshbetz closed 12 years ago

joshbetz commented 12 years ago

Clicking "Login" takes you into the app even if no info is entered. We should probably require valid information before moving into the app.

erasmuss22 commented 12 years ago

I've done some testing on this issue and haven't found any problems with it, but it's something to keep testing. I don't know if the Settings should save changes on viewDidDisappear. I added the same validation on that page, but the warning boxes come up when the next view loads.

joshbetz commented 12 years ago

I thought about saving Settings on viewDidDisappear, but thought it would be easier to just rely on the AppDelegate when the app goes to the background. In makeURL you shouldn't need to pass in the login info because it's global in the app. Also, you can use getEndpoint and pass the method name to get the endpoint and then just use appendWithString to generate the rest of the URL.

joshbetz commented 12 years ago

Nevermind. I see that you were trying to test the password.