search

joshbolduc / vscode-story-explorer

Browse and preview Storybook stories inside VS Code
MIT License
29 stars 1 forks source link

Clicking on "Open Storybook in Browser" closes task #1044

Open icameron opened 2 weeks ago

icameron commented 2 weeks ago

I have set the Launch Strategy to npm and verified the npm script is correct and runs in the cli but after clicking on the "Open Storybook in Browser" icon the terminal window show its running the command but task output looks like its finding a non-existent Storybook server and closing the task

[debug] Attempting launch using npm script creator
[debug] No existing execution found; launching new task
[debug] Scanning process 13852 and child processes for opened port
[debug] Detected Storybook server URL as http://localhost:57642
[debug] Sending request to http://localhost:57642
joshbolduc commented 2 weeks ago

Is there any output in the terminal for the launch task? (This is different than the extension output you've shared above--which is helpful!) It sounds like the Storybook build might be failing for some reason, but not before the server starts listening for connections.

My guess would be there's something different about the way the npm script is invoked via the extension (environment, working directory, etc.) that causes the build to fail.

icameron commented 2 weeks ago

Its on windows machine and it works when the shell is bash. It looks like its related to #840