joshbuddy / http_router

A kick-ass HTTP router for use in Rack
MIT License
198 stars 45 forks source link

Please re-generate the gem from a clean git checkout #14

Closed pwnall closed 13 years ago

pwnall commented 13 years ago

Some files in the latest gem (0.7.8) have weird permission bits, which makes life hard when http_router is installed as a system gem. This is what the main directory looks like after a gem install -- some files don't have read permissions for "other", so I can't require the gem. This happens for some files in the node directory too.

[pwnall@imapwnu:~/workspace/pdf_test]$ ls -l /usr/lib/ruby/gems/1.8/gems/http_router-0.7.8/lib/http_router
total 52
drwxr-xr-x 2 root root  4096 2011-05-13 03:26 node
-rw-rw---- 1 root root  2050 2011-05-13 03:26 node.rb
-rw-r--r-- 1 root root  1033 2011-05-13 03:26 optional_compiler.rb
-rw-r--r-- 1 root root  2108 2011-05-13 03:26 path.rb
drwxr-xr-x 2 root root  4096 2011-05-13 03:26 rack
-rw-r--r-- 1 root root   709 2011-05-13 03:26 rack.rb
-rw-r--r-- 1 root root   500 2011-05-13 03:26 regex_route.rb
-rw-rw---- 1 root root   911 2011-05-13 03:26 request.rb
-rw-rw---- 1 root root   308 2011-05-13 03:26 response.rb
-rw-rw---- 1 root root 10042 2011-05-13 03:26 route.rb
-rw-r--r-- 1 root root    66 2011-05-13 03:26 version.rb

And this is what the directory looks like after a rake install in the gem's source directory. Permissions look normal.

[pwnall@imapwnu:~/workspace]$ ls -l /usr/lib/ruby/gems/1.8/gems/http_router-0.7.8/lib/http_router/
total 52
drwxr-xr-x 2 root root  4096 2011-05-13 03:19 node
-rw-r--r-- 1 root root  2050 2011-05-13 03:19 node.rb
-rw-r--r-- 1 root root  1033 2011-05-13 03:19 optional_compiler.rb
-rw-r--r-- 1 root root  2108 2011-05-13 03:19 path.rb
drwxr-xr-x 2 root root  4096 2011-05-13 03:19 rack
-rw-r--r-- 1 root root   709 2011-05-13 03:19 rack.rb
-rw-r--r-- 1 root root   500 2011-05-13 03:19 regex_route.rb
-rw-r--r-- 1 root root   911 2011-05-13 03:19 request.rb
-rw-r--r-- 1 root root   308 2011-05-13 03:19 response.rb
-rw-r--r-- 1 root root 10042 2011-05-13 03:19 route.rb
-rw-r--r-- 1 root root    66 2011-05-13 03:19 version.rb

Thank you very much!

DAddYE commented 13 years ago

Josh, this problem happens most times, can u add a test to check permissions? So we can prevent this big big big problem?

joshbuddy commented 13 years ago

sry.

joshbuddy commented 13 years ago

I have to fix my umask. So annoying.

DAddYE commented 13 years ago

Do that please, a corrupted version broken 6 websites today ... super annoying :D

DAddYE commented 13 years ago

BTW thanks for you super fast fix! ... also add me to the repo so I can fix it myself

joshbuddy commented 13 years ago

It's not a repo issue, it's a gem issue. At any rate, I've fixed everything on my computer now.