joshbuddy / jsonpath

Ruby implementation of http://goessner.net/articles/JsonPath/
MIT License
447 stars 72 forks source link

remove to_regex dependency and the warnings it causes #128

Closed grosser closed 4 years ago

grosser commented 4 years ago

vendor/bundle/ruby/2.6.0/gems/to_regexp-0.2.1/lib/to_regexp.rb:35: warning:*' interpreted as argument prefix`

fixes https://github.com/joshbuddy/jsonpath/issues/125

grosser commented 4 years ago

it's the default anyway

On Mon, Nov 16, 2020 at 9:45 PM Gergely Brautigam notifications@github.com wrote:

@Skarlso commented on this pull request.

In jsonpath.gemspec https://github.com/joshbuddy/jsonpath/pull/128#discussion_r524897509:

s.authors = ['Joshua Hull', 'Gergely Brautigam'] s.summary = 'Ruby implementation of http://goessner.net/articles/JsonPath/' s.description = 'Ruby implementation of http://goessner.net/articles/JsonPath/.' s.email = ['joshbuddy@gmail.com', 'skarlso777@gmail.com'] s.extra_rdoc_files = ['README.md'] s.files = git ls-files.split("\n") s.homepage = 'https://github.com/joshbuddy/jsonpath'

  • s.rdoc_options = ['--charset=UTF-8']

What was the reason for removing these options?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/joshbuddy/jsonpath/pull/128#pullrequestreview-532037074, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACYZ3PXBJASRCAMSVRZN3SQIEXBANCNFSM4TX4GIFA .

Skarlso commented 4 years ago

So I'm wondering if the test failures are related or not. 🤔

grosser commented 4 years ago

clean PR https://github.com/joshbuddy/jsonpath/pull/129

grosser commented 4 years ago

and https://github.com/joshbuddy/jsonpath/pull/130 while we are at it ...

grosser commented 4 years ago

same error on master ... so merge this and then fix ?

Skarlso commented 4 years ago

I'll take a look at this tonight and fix the build then merge stuff. :) I don't trust a broken system. :)

Skarlso commented 4 years ago

@grosser Please merge master and run this again

grosser commented 4 years ago

jruby still unhappy ... sane as master

Skarlso commented 4 years ago

I'll add the test later.

Jruby has been identified: https://github.com/jruby/jruby/issues/6469