Closed vlad-zhukov closed 7 years ago
@Vlad-Zhukov Good call on moving babel-polyfill, but it should be in the example project's dependencies rather than devDependencies since it actually is getting imported into the global scope and used, right?
And nice catch on babel-preset-react. That was an error I accidentally made when changing the babel presets last night.
As for the package.json repository
change to a shorthand style, are there any downsides or bugs known to exist with using it? I've never used that shorthand style there before.
@joshburgess I personally wouldn't put the pollyfill in for library code. Let the consumer be in charge of that.
Thoughts?
@jshthornton It's only used in the example project. It doesn't get bundled into the library itself.
@joshburgess fixed babel-polyfill.
As for the repository field, it's a documented feature, and yarn also understands it.
@Vlad-Zhukov Thanks.
Also move unused babel-polyfill to the example where it's actually used.