search

joshburgess / redux-most

Most.js based middleware for Redux. Handle async actions with monadic streams & reactive programming.
https://www.npmjs.com/package/redux-most
MIT License
139 stars 14 forks source link

Move babel-preset-react to dev deps, simplify repository field #11

Closed vlad-zhukov closed 7 years ago

vlad-zhukov commented 7 years ago

Also move unused babel-polyfill to the example where it's actually used.

joshburgess commented 7 years ago

@Vlad-Zhukov Good call on moving babel-polyfill, but it should be in the example project's dependencies rather than devDependencies since it actually is getting imported into the global scope and used, right?

And nice catch on babel-preset-react. That was an error I accidentally made when changing the babel presets last night.

As for the package.json repository change to a shorthand style, are there any downsides or bugs known to exist with using it? I've never used that shorthand style there before.

jshthornton commented 7 years ago

@joshburgess I personally wouldn't put the pollyfill in for library code. Let the consumer be in charge of that.

Thoughts?

joshburgess commented 7 years ago

@jshthornton It's only used in the example project. It doesn't get bundled into the library itself.

vlad-zhukov commented 7 years ago

@joshburgess fixed babel-polyfill.

As for the repository field, it's a documented feature, and yarn also understands it.

joshburgess commented 7 years ago

@Vlad-Zhukov Thanks.