search

joshburgess / redux-most

Most.js based middleware for Redux. Handle async actions with monadic streams & reactive programming.
https://www.npmjs.com/package/redux-most
MIT License
139 stars 14 forks source link

Change combineEpics to accept an array of epics #20

Closed joshburgess closed 7 years ago

joshburgess commented 7 years ago

Breaking Change: Change combineEpics to accept an array of epics

I think we should change combineEpics to take in an array of epics instead of a variable amount of arguments. It would have slightly better performance, and it would get rid of the only remaining variadic function in the library.

You would just use it like 

comebineEpics([
  epic1,
  epic2,
  epic3,
])

instead of the current

comebineEpics(
  epic1,
  epic2,
  epic3,
)

It's a very small change, but it is a breaking change to the API. Does anyone have any problems with this?

joshburgess commented 7 years ago

Closing this. It's currently changed in the dev branch and will be in the next version published (redux-most@0.5.0) along with other changes.