search

joshburgess / redux-most

Most.js based middleware for Redux. Handle async actions with monadic streams & reactive programming.
https://www.npmjs.com/package/redux-most
MIT License
139 stars 14 forks source link

Consider changing API to use higher order functions to inject the state stream or store #24

Open joshburgess opened 6 years ago

joshburgess commented 6 years ago

I wanted to get the new API release out, so I held off on rewriting with higher order functions. I might still do it in the future, so I'm creating an issue here to remind myself to come back to the idea to see if it's worth another breaking change.

Link to previous conversation: https://github.com/joshburgess/redux-most/issues/4

kanitsharma commented 5 years ago

@joshburgess I really really like this idea of higher order functions, and since updating to @most/core may need us to bump the version how about we roll this feature out too? :smile:

joshburgess commented 5 years ago

@kanitsharma If you have any time to do a PR for it (or just prototype an idea for me to look at), that would be cool.

I also never added the capability to inject dependencies (like an API client), which is probably something people miss from other libraries.

I'm open to any other ideas you might have for improvements also.

kanitsharma commented 5 years ago

@joshburgess Sure :+1: I will send a PR.

kanitsharma commented 5 years ago

PR #33