search

joshburgess / redux-most

Most.js based middleware for Redux. Handle async actions with monadic streams & reactive programming.
https://www.npmjs.com/package/redux-most
MIT License
139 stars 14 forks source link

Updating to @most/core #31

Closed kanitsharma closed 5 years ago

kanitsharma commented 5 years ago

Big fan of this library, thanks for all the efforts. @most/core provides curried functions and a tree-shakeable package, should we consider updating? Plus updating from @most/core to most 2.0 will be non-breaking.

I will be happy to send a PR :).

joshburgess commented 5 years ago

@kanitsharma Yes, I am interested in upgrading. Sorry, I've been really busy recently. I don't have a whole lot of time at the moment, but I am open to PRs.

The important part will be getting the use of subjects correct. I'm not sure whether or not the current @most/core-compatible solution for subjects still has both async and sync modes, but we MUST use sync mode for timing to function as it does now.

Originally, I used the async mode and someone discovered timing problems (this can be found in the closed issues). So, I switched to sync.

I would also appreciate improvements to the unit tests if you're up for it. :)

joshburgess commented 5 years ago

Also, are you sure this is non-breaking? Can you explain?

I believe we should probably jump to a new major version when doing this.

kanitsharma commented 5 years ago

@joshburgess The most-subject version we are using is pretty old and the latest version which has support for @most/core has breaking changes in the API. I'd suggest you have a look once. https://github.com/mostjs-community/subject However i think we can use @most/create for imperatively pushing actions and epics and it provides a pretty straightforward API to do so, correct me I am wrong :) https://github.com/mostjs/create

kanitsharma commented 5 years ago

Also, are you sure this is non-breaking? Can you explain?

From the most.js repo

image

kanitsharma commented 5 years ago

I would also appreciate improvements to the unit tests if you're up for it. :)

Sure :+1:

kanitsharma commented 5 years ago

hey @joshburgess, i guess I was wrong about @most/create it still has a dependency of Most 1.0. But @most/core already comes with Multicast so I am using that, will land a PR soon :+1:

kanitsharma commented 5 years ago

Closing this as the PR #32 is merged.