search

joshburgess / redux-most

Most.js based middleware for Redux. Handle async actions with monadic streams & reactive programming.
https://www.npmjs.com/package/redux-most
MIT License
139 stars 14 forks source link

Implementation of selectAny #5

Closed jshthornton closed 7 years ago

jshthornton commented 7 years ago

I haven't add the docs yet. I wanted to get your general thoughts, then I will go ahead and document it.

joshburgess commented 7 years ago

At work and only quickly glanced at it. Looks good, but can you also add a type definition in this file so we can make sure to mark it as an array: https://github.com/joshburgess/redux-most/blob/master/index.d.ts

We should also update the readme sections relating to select and add info on the new selectAny, but I can do that if you'd like. Let me know.

Other unrelated ideas:

It would be cool if we could add Flow type definitions to go along with the TypeScript definitions at some point (if you have any interest).

Also, feel free to let me know if you have any other ideas for tests elsewhere in the library.

Thanks, -Josh

joshburgess commented 7 years ago

@jshthornton I went ahead and merged the PR. I just added the TypeScript definition in the index.d.ts file myself. I'm going to write up the documentation in a few minutes. I'll tag you in case you want to add anything.