search

joshcanhelp / wp-rest-api-auth0

Authorize WP REST API calls with access tokens from Auth0
MIT License
5 stars 1 forks source link

Add release job to CI #4

Closed szepeviktor closed 3 years ago

szepeviktor commented 3 years ago

Needs an English speaking person who edits README.

Closes #3

szepeviktor commented 3 years ago

https://github.com/szepeviktor/wp-rest-api-auth0/releases 👀

joshcanhelp commented 3 years ago

@szepeviktor - Thank you for this! Just so I'm clear, this creates a release ZIP with the dependencies installed to make the manual process a bit easier? Does this (or is there any way to) make a ZIP that you can just upload into the admin? Maybe by adding plugin headers to the main file?

szepeviktor commented 3 years ago

a ZIP that you can just upload into the admin

Is there a way to install an MU plugin from WordPress admin?? AFAIK only normal plugins can be installed that way.

joshcanhelp commented 3 years ago

You can have the same file in MU plugins as you can in regular plugins and it will work, as long as you have a plugin header on the file (IIRC).

szepeviktor commented 3 years ago

I leave this plugin up to you. I am sorry for the noise. I manufacture plugins for agency use done by my playbook. (basically 1 composer.json)

If one manufactures plugins for the masses without expertise it'll be slower, less secure, basically you have to put in safeguards because the lack of expertise of the user. I'm an old-style guy: hosting/running is only for scientists. 👨‍🔬

joshcanhelp commented 3 years ago

@szepeviktor - This is not noise at all and no apology needed! I really appreciate your contributions.

I'd like to get this working for as many different use cases as possible, if possible. I just don't see how including the main file, which calls add_action could even happen with this as a Composer package unless you're manually requiring the main file at some point on your own, which will break if the file structure in the package breaks.

szepeviktor commented 3 years ago

I see 2 ways.

  1. Average user downloads a prepared ZIP file from GitHub release and unpacks it to wp-content/mu-plugins/
  2. Agencies do composer require ... and copy the bundled loader to wp-content/mu-plugins/
szepeviktor commented 3 years ago

Thank you.

szepeviktor commented 3 years ago

Please modify README accordingly.