search

joshcgray / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

Summary #4

Open Tooconfident opened 7 years ago

Tooconfident commented 7 years ago

Grade: Meets expectations

Solid job here! You have shown good knowledge of how html and css communicate with each other and did well creating classes to assist with your css selectors. There isn't much to improve on, just suggestions of how you can make things even cleaner for yourself. Your CSS is overall DRY(Don't Repeat Yourself) so keep holding on to those principles of staying away from repetitive code. Look into recognizing when universal styles are present vs. unique styles so you can better decide appropriate places for classes and id's. Nice job!

Resources that can help:

https://www.slideshare.net/jeremyclarke/dry-css-a-dontrepeatyourself-methodology-for-creating-efficient-unified-and-scalable-stylesheets http://vanseodesign.com/css/dry-principles/ https://css-tricks.com/the-difference-between-id-and-class/

joshcgray commented 7 years ago

Thanks for the comments and recommendations. It's review is a great practice to really fine tune skills. Also, thanks for the additional material. I'll be sure to read through.