Wrapper updates and other sanitation

mgalgs commented 1 year ago

This PR contains a few fixes and improvements:

Pulled in #52 (preserving authorship) and fixed merge conflicts (cc: @ncaq). This patch is necessary to keep up with updates from chatgpt-wrapper, which has not only changed their API, but also deprecated support for the 'browser' backend. The stop-gap of #53 is not enough.
Add setting to avoid automatically running pip install. Although IMO we should just remove the automatic pip install altogether. Installing Python packages is the kind of thing the user should do themselves (and we already have instructions for that in the README) since an automatic installation could end up adding packages to an unexpected location, like the user's system python site packages directory. Let me know if you're okay with removing it altogether and I'll rework the patch to do that instead of adding this new setting.
Renamed python-interpreter to chatgpt-python-interpreter (for "namespacing").
Check that the user has set their OPENAI_API_KEY environment variable.

joshcho commented 1 year ago

Hi @mgalgs, thanks for the pull request. The automatic pip install needed to be taken out, thanks for pointing it out.

https://github.com/joshcho/ChatGPT.el/commit/c38c9150b4f156c90c44f330aa0cd2497d66f8c5 is a major refactor that removes the Python server altogether. It should address all the concerns that you have brought up.

Closing for now, but please reopen if there is anything I missed.

mgalgs commented 1 year ago

Nice!!

joshcho / ChatGPT.el