search

joshday / DataGenerator.jl

Generate data for generalized linear models and more
Other
3 stars 1 forks source link

combine efforts #1

Open Evizero opened 8 years ago

Evizero commented 8 years ago

Hey @joshday !

I just saw this package when looking at your JuliaCon slides (nice talk by the way).

Do you think it might be worth to combine efforts with MLDataUtils? see https://github.com/JuliaML/MLDataUtils.jl#data-generators

cheers

joshday commented 8 years ago

Hey, thanks!

Yeah, I think we should. Looks like we already share the same syntax. I've used DataGenerator just to make some toy datasets as a sanity check for OnlineStats and SparseRegression. How do you feel about adding a dependency for Distributions?

Evizero commented 8 years ago

adding a dependency for Distributions

No objections! Right now I am using the scapegoat of allowing a noise "function". It would probably even be cleaner to go the Distributions route!

joshday commented 8 years ago

Good deal. I'll add a comment here when I have time to put together a PR (I switched to 0.5 yesterday, so I'll be fixing a few of my packages today). Otherwise, feel free to copy/paste/change anything from here.

Evizero commented 8 years ago

Ok, nice! I have to get MLDataUtils ready for 0.5 soon anyway so I'll probably do this then in one go