search

joshday / OnlineStats.jl

⚡ Single-pass algorithms for statistics
https://joshday.github.io/OnlineStats.jl/latest/
MIT License
831 stars 62 forks source link

Use Period in MovingTimeWindow #209

Closed JoaoAparicio closed 4 years ago

JoaoAparicio commented 4 years ago

The MovingTimeWindow is currently

MovingTimeWindow{T<:TimeType, S, D<:DatePeriod} <: OnlineStat{TwoThings{T,S}}

This commit changes DatePeriod to Period

MovingTimeWindow{T<:TimeType, S, D<:Period} <: OnlineStat{TwoThings{T,S}}

See https://en.wikibooks.org/wiki/Introducing_Julia/Working_with_dates_and_times

codecov[bot] commented 4 years ago

Codecov Report

Merging #209 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #209   +/-   ##
=======================================
  Coverage   66.32%   66.32%           
=======================================
  Files          17       17           
  Lines        1461     1461           
=======================================
  Hits          969      969           
  Misses        492      492
Impacted Files Coverage Δ
src/stats/stats.jl 87.85% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e554858...482d0d1. Read the comment docs.

joshday commented 4 years ago

Cool, thanks for the PR!