search

joshdholtz / DeckUI

Swift DSL for writing slide decks in Xcode
MIT License
601 stars 27 forks source link

`SlideDirection` -> `SlideTransition` #5

Closed yonomitt closed 1 year ago

yonomitt commented 1 year ago

In the future, it might be handy to add more transitions between slides. For instance, in Keynote, I use Dissolve quite often, and would miss it here. This would require adding a new case to the SlideDirection enum.

However, at the point of adding more transition types, the name no longer makes sense. It might be better to rename it to SlideTransition to more accurately reflect the functionality.

joshdholtz commented 1 year ago

I completely agree with this! I will get this renamed 😊