search

joshdholtz / Sentry-Android

[Deprecated] Use official "raven-java" library
https://github.com/getsentry/sentry-java
MIT License
180 stars 48 forks source link

Ability to send more breadcrumbs? #117

Closed edenman closed 7 years ago

edenman commented 7 years ago

I'd really like to use breadcrumbs as a log of what happened leading up to the crash, but 10 breadcrumbs is a pretty narrow window of events. Any chance this could be customized? I can put together a PR if that would be helpful.

marcomorain commented 7 years ago

Hi @edenman sorry I'm only seeing this now.

tbh the current limit of 10 was plucked from the air.

What would be a better default?

I'll do a PR to make it configurable

edenman commented 7 years ago

@marcomorain awesome! 10 seems like a reasonable default to me.

edenman commented 7 years ago

...but after looking at the commit, i'm totally fine with 100 that you changed it to :)