joshdholtz / Sentry-Android

[Deprecated] Use official "raven-java" library
https://github.com/getsentry/sentry-java
MIT License
180 stars 48 forks source link

Setting of environment #123

Closed laurenceputra closed 7 years ago

laurenceputra commented 7 years ago

Currently I'm not able to set the environment of the app without making modifications to the library. Possible to expose a function to do that?

marcomorain commented 7 years ago

Hi @laurenceputra that sounds like a good addition to the library. We'd happily accept a PR if you have the time.

I would do it by putting a public method on the SentryEventBuilder class setEnvironment(String env).

MihaelIsaev commented 7 years ago

Could someone please build a new version and upload it to jCenter? I want to use environment feature https://github.com/joshdholtz/Sentry-Android/pull/124/commits/7a5ebc44a5a0b329e37ecd9005a83e11f350f3f5

seljabali commented 7 years ago

@joshdholtz?

joshdholtz commented 7 years ago

@MihaelIsaev @seljabali Popped out a new build for you (v1.6.2). Sorry about taking so long!

seljabali commented 7 years ago

Thank you @joshdholtz

joshdholtz commented 7 years ago

Not a problem ❤️