search

joshdholtz / Sentry-Android

[Deprecated] Use official "raven-java" library
https://github.com/getsentry/sentry-java
MIT License
180 stars 48 forks source link

Add `setRelease` #34

Closed grabbou closed 8 years ago

grabbou commented 8 years ago

Fixes #33

These attributes are listed here on the Sentry page: https://docs.getsentry.com/hosted/clientdev/attributes/

9mm commented 8 years ago

This would be truly amazing, need this on my project at this exact moment.

:+1:

grabbou commented 8 years ago

@9mm yeah, me too! Don't know your specific use-cases, but feel free to add in few more things :)

9mm commented 8 years ago

Actually you hit the nail on the head, it's exactly what I need.

joshdholtz commented 8 years ago

@grabbou Thanks for the contribution! :heart: Merging in :+1: I will comment back here when its up on jcenter

grabbou commented 8 years ago

Thank you!

joshdholtz commented 8 years ago

@grabbou Not a problem! May take a while though :grimacing: I re-installed OS X on my machine and now I think I need to reset how to upload the package :wink:

9mm commented 8 years ago

Nice!

joshdholtz commented 8 years ago

Everything should be updated in version 1.2.2 - https://github.com/joshdholtz/Sentry-Android/releases/tag/1.2.2

If one of you would be able to confirm this that would be great :blush:

Christophe31 commented 8 years ago

It may be stupid but I think whatever the name you give, android version info (ex:4.4.1) should also be in the message. It can be useful debug info…

builder.getTags().put("system_version", Build.VERSION.RELEASE);

(I add it each time…)

grabbou commented 8 years ago

@joshdholtz builds so far with new methods, so i think it works! thanks

joshdholtz commented 8 years ago

@Christophe31 Do you mind creating an issue for that? I would be happy to add that in :blush:

joshdholtz commented 8 years ago

And thanks for the feedback @grabbou! Appreciate it :heart: