search

joshdick / onedark.vim

A dark Vim/Neovim color scheme inspired by Atom's One Dark syntax theme.
MIT License
3.89k stars 532 forks source link

Illegible diffs #311

Open xmready opened 2 years ago

xmready commented 2 years ago

Terminal Emulator Info

GNOME Terminal 3.44.0 using VTE 0.68.0 +BIDI +GNUTLS +ICU +SYSTEMD

Output From vim --version

VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Apr 18 2022 19:26:30)
Included patches: 1-3995
Modified by team+vim@tracker.debian.org
Compiled by team+vim@tracker.debian.org
Huge version without GUI.

Issue Description

Hi! The current column and line for changes in a diff is illegible with set cursorcolumn and set cursorline. Here is what it looks like with onedark: image

Here is what it looks like with everforest: image

You can see the difference in legibility for the column and line the cursor is on; onedark makes them unreadable and almost black. If this isn't something you are willing to change, which highlight group would I have to mess with in order to fix it? Un-setting the set cursorcolumn and set cursorline fixes it, but I like these options set.

Also, I would like to put in my vote to have the underlining on changed lines replaced with a darker shade of background color, which would still offer the ability to tell which parts of the line have actually changed. Here is an example of what that looks like in other themes: image

Thank you for onedark Josh, I really do love it.

CoelacanthusHex commented 2 years ago

Same problem here, Arch Linux with vim 9.0.0158 and konsole 22.04.3