search

joshdk / go-junit

🐜 Go library for ingesting JUnit XML reports
MIT License
59 stars 21 forks source link

Make Test status type public to package #15

Closed arjunpur closed 5 years ago

arjunpur commented 5 years ago

Proposed change to address: https://github.com/joshdk/go-junit/issues/14

joshdk commented 5 years ago

Additionally, I've also configured CircleCI to build forked PRs for this repo, so you should see lint/test/build status reported next time a commit it pushed.

arjunpur commented 5 years ago

Much appreciated @joshdk. There are currently two failing steps in CircleCI:

1)

#!/bin/bash -eo pipefail
gometalinter
gometalinter: error: unknown linters: gas, megacheck
Exited with code 1

2)

#!/bin/bash -eo pipefail
cat test-results/report.log | go-junit-report -go-version $GOLANG_VERSION > test-results/report.xml
cat: test-results/report.log: No such file or directory
Exited with code 1
joshdk commented 5 years ago

I expected CI was going to fail as such... I'm going to go and merge your PR, and then a bunch of small updates (see #16) to update the gometalinter checks.

Thank you again @arjunpur for your contribution! 🎉