Parse time durations containing commas

joshdk / go-junit

🐜 Go library for ingesting JUnit XML reports

MIT License

59 stars 21 forks source link

Parse time durations containing commas #39

Closed vistaarjuneja closed 3 years ago

vistaarjuneja commented 3 years ago

Issue: https://github.com/joshdk/go-junit/issues/38 For tests longer than 17 minutes, the duration field goes into 4 digits. The maven surefire plugin outputs this in a comma separated format, e.g, 1,234.56. We should remove commas before trying to parse the duration field. Ref: junit-team/junit5#1381

joshdk commented 3 years ago

Hi @vistaarjuneja, wanted to reach out again! Did you have any thoughts on the above feedback? If things were addressed I would be happy to merge. 😄

Thanks again, cheers!

vistaarjuneja commented 3 years ago

Totally missed the previous message. Thanks for reviewing! Let me know if it looks better now