joshdoe / gst-plugins-vision

GStreamer plugins related to the field of machine vision
Other
134 stars 50 forks source link

Axis #41

Closed mrstecklo closed 4 years ago

mrstecklo commented 4 years ago

Made some refactoring to gstpylonsrc.c. There were lots of repetative code (e.g. color adjustments for red, green, blue is identical).

I'm improving only pylonsrc plugin and now I'm heading towards using PylonFeaturePersistenceLoad() to use configuration files to set all features. Generally it's because of not all of them work properly on both my cameras. For example one camera does not have AcquisitionFrameRate feature, but has AquisitionFrameRateAbs. Using configuration file will somewhat conflict with some features being set to default if not set explicitly. So I will use tri-state flags to determine if feature is set/notset/default. If configuration file is not used, all features will be processed in "legacy" mode for compatibility, i.e if it is not set explicitly, it is default. If configuration file is used, all features will be marked as notset if not set explicitly.

I'm also thinking of modifying CMakeLists to be able to specify GStreamer install prefix manually, because I've installed GStreamer with gst-build and it does not set any environment variables and pkg-config knows nothing about installation.