search

joshdoe / gst-plugins-vision

GStreamer plugins related to the field of machine vision
Other
134 stars 50 forks source link

pylonsrc: Corrupt frames / rebased #51

Closed mrstecklo closed 3 years ago

mrstecklo commented 3 years ago

Here are the changes made in #32 by @AB-Eskild. I've rebased them on top of my changes, as there were a lot of refactoring and merge conflicts are nontrivial. Thanks again to @AB-Eskild. Hope to see his work being helpful to others

joshdoe commented 3 years ago

Thanks. I'm not a big fan of the property name failrate, as it's not a rate, but I don't feel too strongly about it, and don't have a perfect replacement suggestion. If you happen to have a better name and feel like changing it, go ahead, otherwise let me know and I'll just merge it as is.

mrstecklo commented 3 years ago

Maybe something like retrylimit or framedroplimit

mrstecklo commented 3 years ago

It's difficult for me to judge as I'm not native speaker

joshdoe commented 3 years ago

Both of those are good suggestions, but maybe like framedroplimit better. I can refactor to use framedroplimit if you'd like, or you can, let me know. Thanks.

As an aside, I've been used to seeing property names in GStreamer with - separating words, but we have so many properties in this element we may as well leave them as is, or make it as part of a big refactor PR if anyone cares enough to do so.

mrstecklo commented 3 years ago

I've renamed failrate to frame-drop-limit. And separated words in other new property names with dash. Also squashed second commit (originally 1a68796)