joshdon / ProjectSand

HTML5 Sand Falling Game
https://www.projectsand.io/
GNU General Public License v3.0
60 stars 33 forks source link

New Element Idea #4

Closed AltruisticNut closed 2 years ago

AltruisticNut commented 2 years ago

Hi! Been having a lot of fun with this game, it's really been fun to mess around with and figure out JavaScript. I wanted to show/submit a new element I created from the MYSTERY & FIRE interaction over on my own fork. You can test it out over there, if you'd like. You're free to change the name and whatever you'd like to.

I ported it into the vanilla elements.js file for easy conversion below. (Had to change the file extension to .txt though, so you'll need to swap it back. Sorry!).

elements.txt

joshdon commented 2 years ago

Just checked out your fork, some fun ideas in there.

Which element are you proposing? It looks like mystery + fire still acts as a randomizer.

In the future I recommend opening a pull request to make the proposed diff clearer :)

AltruisticNut commented 2 years ago

Thanks for checking put my fork! Sorry I wasn't clear, but I was referring to the Thanos/Dust element combo, which is based on the MYSTERY & FIRE interaction in it's code and functionality, the actual interaction is still the same. Also, I'll be sure to make a pull request next time, I'm still pretty new to Github lol.

joshdon commented 2 years ago

Ah, gotcha. I'm traveling at the moment but I'll take a closer look when I get back.

joshdon commented 2 years ago

The humans/reproduction/thanos/corrupt interactions are interesting :) I don't think those are quite ready to merge though, but the humans are a fun idea.

The nanites one is actually quite nice. One tweak though that I'd recommend: the speed at which it clones in the upwards direction is nearly instantaneous due to the fact that the canvas is iterated from bottom to top. You can check out how I fixed this type of issue for FUSE.

AltruisticNut commented 2 years ago

Happy to see you had fun with some of my elements! I'll fix up the Nanites element and send in a pull request once it's ready.

joshdon commented 2 years ago

Sounds good!